action-validator icon indicating copy to clipboard operation
action-validator copied to clipboard

Poor Information returned on Windows through pre-commit

Open jdewinter3Cloud opened this issue 2 years ago • 1 comments

Tried adding this to my project, and this is what I see from output:

action validator.........................................................Failed
- hook id: action-validator
- exit code: 1

It would be helpful if there was more information on how to debug this issue, and how to see where there are bad parts of the GitHub files.

jdewinter3Cloud avatar May 03 '23 01:05 jdewinter3Cloud

The action-validator tool itself reports the nature of the failure that occurred, and the script that pre-commit uses to run action-validator does not appear to suppress that output, so this would seem to be a problem with pre-commit itself.

If there's any way that the .pre-commit-hooks.yaml that we ship could be improved, to tell pre-commit to display output on failure, I'd accept a PR to fix that, but I'm not a pre-commit user myself, and don't have a great desire to learn anything about it, so I won't be able to fix this myself. Perhaps @MatthieuBizien has some ideas, as he wrote the original pre-commit PR.

mpalmer avatar May 03 '23 03:05 mpalmer