printf icon indicating copy to clipboard operation
printf copied to clipboard

Unittest redesign

Open ledvinap opened this issue 5 years ago • 3 comments

Build printf using C Convert most tests in test_suite to use macro Fix catch2

New tests use CHECK now, but it may be reverted easily back to REQUIRE.

ledvinap avatar May 02 '19 18:05 ledvinap

Codecov Report

Merging #58 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #58   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         359    355    -4     
=====================================
- Hits          359    355    -4
Impacted Files Coverage Δ
printf.c 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21eea6c...ccf6149. Read the comment docs.

codecov-io avatar May 02 '19 18:05 codecov-io

Hello. Is there anything I can do ?

The coverage report is strange - missing line is always-false branch dependent on type size (sizeof(uintptr_t) == sizeof(long long);), it shouldn't be covered even before this change, but c++ is probably optimizing a bit even with -O0

ledvinap avatar May 29 '19 10:05 ledvinap

@ledvinap : So, some of these changes aren't strictly about the unit tests, and are covered by other PRs. Also, if you check out my fork, you'll notice I've merged some of those proposed changes, as this repo has not seen much traction for a while. If you're interested - I would appreciate PR against that fork.

eyalroz avatar Jun 28 '21 21:06 eyalroz