zilla-slab icon indicating copy to clipboard operation
zilla-slab copied to clipboard

Optimize build script

Open shinenelson opened this issue 7 years ago • 2 comments

The build script was dependent on the directory in which it was triggered. This could cause inconsistency if the script was triggered from outside it's own directory.

The global variables allows the script to run with respect to the root of the repository allowing more flexibility, stability and consistency.

Also, there were multiple mv commands that could be merged into a single command.

shinenelson avatar Aug 31 '17 23:08 shinenelson

/cc @m4rc1e

alexgibson avatar Sep 01 '17 07:09 alexgibson

@shinenelson thank you for the pr. I'll do a quick review.

m4rc1e avatar Sep 01 '17 09:09 m4rc1e