web-ext
web-ext copied to clipboard
mozilla
Add a new mandatory CLI flag that states source code information
Is this a feature request or a bug?
Feature request
What is the current behavior?
A common issue with API submissions is that the add-on itself uses machine-generated code but developers do not attach source code to it. Some don't know, others forgot or don't do it for other reasons.
What is the expected or desired behavior?
To help reviewers and reduce back and forth with developers, web-ext should add a mandatory CLI flag that allows to pass a source code zip file and a different one to state that source code is not needed. The developer hub already does this, and the API should have a similar feature.
web-ext currently works by zipping --source-dir first and uploading that so we should consider how another source directory would work in that workflow. If it's machine-generated code that it's very likely that web-ext is used in some kind of script, so perhaps specifying another directory that web-ext would zip up too would be more appropriate.
@rpl @willdurand @Rob--W can I get your thoughts on how this feature should work?
The next triage meeting to discuss this is in three weeks.
Here are my thoughts:
The option being mandatory would require a major version bump.
I would accept a zip file as parameter, and not zip directories automatically. Accepting a directory carries the risk of inadvertently uploading files that the dev didn't intend to, and would also need support for including/excluding specific files/directories. I can be convinced otherwise.
The option being mandatory would require a major version bump.
We are working on v8 right now, so that part won't be a problem.
