web-ext icon indicating copy to clipboard operation
web-ext copied to clipboard

web-ext should tell users when a new version is available

Open willdurand opened this issue 3 years ago • 2 comments

It'd be nice to notify users when web-ext has a new version available, similar to what npm does. That would allow most users to always use the latest version.

willdurand avatar Oct 26 '22 10:10 willdurand

@willdurand this looks like a duplicate of #142, which has been fixed long time ago in #676. The check is being done using the update-notifier dependency (used in checkForUpdates defined in src/util/updates.js which is called from program.js here when running in production modehttps://github.com/mozilla/web-ext/blob/b6a546afea75244fb6925e6f74a25d2636bd6048/src/program.js#L303-L305).

I've seen the updates notification in the production install I have installed on my desktop machine, the test is a unit test and so there is a chance that we may have broken it recently and the test didn't fail (e.g. when we removed webpack, if globalEnv isn't 'production' in the builds released on npm).

I've double-checked if we are correctly replacing the environment var in defaultGlobalEnv declaration here in program.js as part of the babel transpiling and it looks to be the case (see the transpiled result in the last released version https://unpkg.com/browse/[email protected]/lib/program.js).

And so it seems that we can close this as a duplicate?

rpl avatar Oct 27 '22 11:10 rpl

Can be closed.

fregante avatar Aug 23 '24 12:08 fregante