web-ext
web-ext copied to clipboard
chore(deps): update dependency flow-bin to v0.185.2
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| flow-bin (changelog) | 0.182.0 -> 0.188.1 |
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
- [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.
This PR has been generated by Mend Renovate. View repository job log here.
Codecov Report
Merging #2464 (d171f22) into master (6b87403) will increase coverage by
0.00%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #2464 +/- ##
=======================================
Coverage 99.52% 99.52%
=======================================
Files 32 32
Lines 1677 1682 +5
=======================================
+ Hits 1669 1674 +5
Misses 8 8
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/cmd/build.js | 100.00% <100.00%> (ø) |
|
| src/extension-runners/firefox-android.js | 100.00% <100.00%> (ø) |
|
| src/firefox/preferences.js | 100.00% <100.00%> (ø) |
|
| src/util/adb.js | 100.00% <100.00%> (ø) |
|
| src/util/file-filter.js | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@willdurand no need to rush on this, but I looked into it and so I updated this PR to apply the tweaks needed to successfully run flow >= 0.185.0
The changes from d171f22 are related to two changes on the flowtype side:
-
a new
inference_mode=constrain_writesseems to have been introduced a few flowtype versions ago, but in 0.185.0 it did become the default. The new inference mode seems to be a bit more strict than the previous one and so I had to add some more explicit type annotations and even apply some tweaks to let help flow with the types it should expect -
the
log.fileoption seems to be rejected now, I digged a bit into flow ocaml source and the option type seems to technically be still there, but somehow its support got lost somewhere else (even if there is no trace of its removal in the changelog :shrug:, which seems to suggest it may not be an actual deprecation, more likely a regression that wasn't caught by any test), honestly I didn't care as much to be willing to dig more into it :-P
Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.