uniffi-rs icon indicating copy to clipboard operation
uniffi-rs copied to clipboard

Create python tutorial.

Open gogo2464 opened this issue 2 years ago • 15 comments

I am going to reuse my template for the tutorial.

gogo2464 avatar Jul 10 '23 07:07 gogo2464

The minimal example compiles. I tested it in my system. Do you would like cicd to test it?

gogo2464 avatar Jul 10 '23 12:07 gogo2464

I agree. This example is long. I might remove class build(_build): content. But then I will need to run 2 commands from batch or from bash.

gogo2464 avatar Jul 10 '23 13:07 gogo2464

for a weird reason the tesing fails without uniffi_macro = "*"

gogo2464 avatar Jul 11 '23 17:07 gogo2464

It does not fails with uniffi_macro. Let me try without and with a rebase please.

gogo2464 avatar Jul 11 '23 18:07 gogo2464

Yes I maintain that the cicd does not pass over with not uniffi_macro.

gogo2464 avatar Jul 11 '23 21:07 gogo2464

Yes I maintain that the cicd does not pass over with not uniffi_macro.

Then that's an issue we should address. We're not gonna recommend star-dependencies in official examples; example should showcase best practices.

badboy avatar Jul 12 '23 08:07 badboy

I have already reported. I have not found why it still works with not uniffi_macro for some people. https://github.com/mozilla/uniffi-rs/issues/1645

gogo2464 avatar Jul 12 '23 08:07 gogo2464

Just as a note: I'll try to help pushing this forward tomorrow.

badboy avatar Jul 17 '23 15:07 badboy

I appreciate the effort, but after going through this I think it's easier if I take this over and prepare a minimal example we can land.

yes sure. Then I will update.

gogo2464 avatar Jul 21 '23 11:07 gogo2464

Hello. I am confused. Is it expected to wait for the new python template .pytoml in order to document it or can I continue with setup.py?

gogo2464 avatar Aug 11 '23 09:08 gogo2464

Hey, sorry. I didn't yet have time to work on this. As I said I will take this over and prepare the docs in a way we want to land them. There's currently no more work for you to be done.

badboy avatar Aug 11 '23 09:08 badboy

Alright. Do I document the old way with a deprecated mention in the doc?

gogo2464 avatar Aug 11 '23 10:08 gogo2464

or I just wait at least.

gogo2464 avatar Aug 11 '23 10:08 gogo2464

Hey, sorry. I didn't yet have time to work on this. As I said I will take this over and prepare the docs in a way we want to land them. There's currently no more work for you to be done.

alright. I spent some days to code. It could be fine if I can merge something. Tell me if it is not necessary please?

gogo2464 avatar Aug 28 '23 09:08 gogo2464

Hello I read the page https://mozilla.github.io/uniffi-rs/python/configuration.html . Is this issue fixed? We may could set my way for an optional python tutorial on the old setup.py?

gogo2464 avatar Nov 29 '23 21:11 gogo2464