treeherder icon indicating copy to clipboard operation
treeherder copied to clipboard

Fix default props and brittle selectJob logic

Open camd opened this issue 1 month ago • 1 comments

This is an extension of PR #9115. So that should be merged first.

I separated many of the changes into separate commits to attempt to help with reviewing. You may consider reviewing each commit separately.

Also fixed many test warnings.

camd avatar Dec 14 '25 21:12 camd

Codecov Report

:x: Patch coverage is 68.31876% with 326 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 81.19%. Comparing base (a82c683) to head (ef120fb).

Files with missing lines Patch % Lines
ui/job-view/pushes/Push.jsx 65.31% 77 Missing :warning:
ui/job-view/pushes/FuzzyJobFinder.jsx 52.94% 31 Missing and 1 partial :warning:
ui/hooks/useDebounce.js 0.00% 22 Missing and 2 partials :warning:
ui/job-view/pushes/PushJobs.jsx 70.73% 12 Missing :warning:
ui/intermittent-failures/DateRangePicker.jsx 0.00% 10 Missing :warning:
ui/intermittent-failures/Layout.jsx 0.00% 10 Missing :warning:
ui/shared/RevisionInformation.jsx 0.00% 9 Missing :warning:
ui/job-view/pushes/PushHeader.jsx 76.47% 7 Missing and 1 partial :warning:
ui/job-view/details/summary/SummaryPanel.jsx 0.00% 7 Missing :warning:
ui/intermittent-failures/BugDetailsView.jsx 0.00% 5 Missing :warning:
... and 61 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9124      +/-   ##
==========================================
+ Coverage   80.01%   81.19%   +1.17%     
==========================================
  Files         601      604       +3     
  Lines       32715    33867    +1152     
  Branches     3314     3191     -123     
==========================================
+ Hits        26178    27498    +1320     
+ Misses       6371     6213     -158     
+ Partials      166      156      -10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Dec 15 '25 18:12 codecov-commenter