treeherder icon indicating copy to clipboard operation
treeherder copied to clipboard

fix: Front-end React deprecations

Open camd opened this issue 4 months ago • 1 comments

Not complete yet, and not exhaustive. But this fixes a LOT of them. It's large, so I tried to break types of fixes into different commits. But I wasn't perfect in that regard. I started getting more careful in the later commits. 😆

A few details:

  • I build it on top of the react-bootstrap PR, as it is a natural continuation.
  • I added new Puppeteer tests and fixed up the existing ones. I will ensure they do not run in CI by default, though.
  • I also fixed up many of the warnings and errors in the React Testing Library tests.
  • Upgraded the hot-reloading package, which was causing warnings as well.
  • Upgraded the "Helmet" package which handles headers and metadata, etc.

TODO:

  • [ ] Rebase on master when reactstrap is merged
  • [ ] Break up into different PRs for each app: Treeherder, Push Health, IFV and Perfherder
  • [ ] Have CI run the puppeteer tests by default
  • [ ] Check how slow it is
  • [ ] Does it increase coverage

camd avatar Sep 13 '25 17:09 camd

Please rebase here when you find time.

Archaeopteryx avatar Sep 18 '25 19:09 Archaeopteryx

Codecov Report

:x: Patch coverage is 68.19512% with 326 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 81.13%. Comparing base (5d64caf) to head (e01b69e). :warning: Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
ui/job-view/pushes/Push.jsx 64.67% 72 Missing and 5 partials :warning:
ui/job-view/pushes/FuzzyJobFinder.jsx 52.94% 31 Missing and 1 partial :warning:
ui/hooks/useDebounce.js 0.00% 22 Missing and 2 partials :warning:
ui/job-view/pushes/PushJobs.jsx 70.73% 10 Missing and 2 partials :warning:
ui/intermittent-failures/DateRangePicker.jsx 0.00% 10 Missing :warning:
ui/intermittent-failures/Layout.jsx 0.00% 10 Missing :warning:
ui/shared/RevisionInformation.jsx 0.00% 9 Missing :warning:
ui/job-view/pushes/PushHeader.jsx 76.47% 7 Missing and 1 partial :warning:
ui/job-view/details/summary/SummaryPanel.jsx 0.00% 7 Missing :warning:
ui/intermittent-failures/BugDetailsView.jsx 0.00% 5 Missing :warning:
... and 61 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8971      +/-   ##
==========================================
+ Coverage   79.95%   81.13%   +1.18%     
==========================================
  Files         600      603       +3     
  Lines       32560    33712    +1152     
  Branches     3310     3248      -62     
==========================================
+ Hits        26032    27352    +1320     
+ Misses       6362     5988     -374     
- Partials      166      372     +206     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Dec 20 '25 23:12 codecov-commenter