treeherder icon indicating copy to clipboard operation
treeherder copied to clipboard

Show common alert ID

Open alexandru-io opened this issue 2 years ago • 5 comments

alexandru-io avatar Oct 07 '22 12:10 alexandru-io

image

alexandru-io avatar Oct 11 '22 07:10 alexandru-io

I have some suggestions:

  • I would say that "(log in as a sheriff to create)" should not be displayed there since the common alert already exists.
  • Alert number for common alerts is orange and for the usual alerts is blue colored.

beatrice-acasandrei avatar Oct 11 '22 08:10 beatrice-acasandrei

* Alert number for common alerts is orange and for the usual alerts is blue colored.

isn't already orange?

alexandru-io avatar Oct 11 '22 09:10 alexandru-io

image image

alexandru-io avatar Oct 11 '22 09:10 alexandru-io

* Alert number for common alerts is orange and for the usual alerts is blue colored.

isn't already orange?

In my opinion you should keep the original color, which is blue. You already have the "Common alert" text to differentiate the alerts and I don't see a reason to not keep the original design.

beatrice-acasandrei avatar Oct 12 '22 08:10 beatrice-acasandrei

Codecov Report

Base: 90.75% // Head: 90.75% // No change to project coverage :thumbsup:

Coverage data is based on head (1a38aa7) compared to base (4ad7db9). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7541   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         294      294           
  Lines       14966    14966           
=======================================
  Hits        13582    13582           
  Misses       1384     1384           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Oct 25 '22 09:10 codecov-commenter

image

alexandru-io avatar Oct 26 '22 14:10 alexandru-io

if you rebase this on upstream/master, you will fix the issue with circleci: builds.

jmaher avatar Nov 15 '22 22:11 jmaher

please rebase on master branch to pick up changes to fix the issue with the broken builds job.

jmaher avatar Nov 25 '22 16:11 jmaher