treeherder icon indicating copy to clipboard operation
treeherder copied to clipboard

Add "CMake Error at" as an error keyword

Open glandium opened this issue 3 years ago • 3 comments

glandium avatar Nov 18 '21 02:11 glandium

@sarah-clements @Archaeopteryx what do you think ? seems trivial enough

sylvestre avatar Jan 04 '22 09:01 sylvestre

The code would work but adding additional keywords is expensive because every line in every log gets checked against it and only 2 bugs have been logged for such failures in the last 2 years (bug 1736502, bug 1748369). The tasks failed and the issues got caught, keeping the current state without the additional rule looks like the better trade-off.

Archaeopteryx avatar Jan 04 '22 10:01 Archaeopteryx

@glandium do you have plans to continue working on this, or should we close this PR?

jmaher avatar Aug 18 '22 19:08 jmaher