probe-scraper icon indicating copy to clipboard operation
probe-scraper copied to clipboard
verified publisher icon mozilla

Fixup old non-number values & expressions in histogram.json

Open georgf opened this issue 9 years ago • 3 comments

Old histogram.json files contain non-number values & expressions for fields as "n_values". We need to properly handle these and convert the literals to useful values.

georgf avatar Mar 30 '17 12:03 georgf

We should also test coverage for this, to make sure it doesn't regress.

georgf avatar Apr 11 '17 09:04 georgf

In order to get the buckets back we had to disable in #63 we can do:

  • Turn strings into ints (when possible, e.g. "10000").
  • Ignore expressions ("16 * 1024") and assume 0 (so it's easy)
  • everything new has proper ints anyway so we can generate the buckets

badboy avatar Jan 25 '19 13:01 badboy

For now we could also just ignore a specific set of old probes that had string expressions. Per bug 1245910 this should only affect Histograms.json fields and only Firefox releases before Fx 47.

If we wanted to fix these properly in the future and get real values out... We could have a "fixup preprocessing step" specific to the hg.m.o Histograms.json source.

georgf avatar Jan 25 '19 14:01 georgf