pontoon icon indicating copy to clipboard operation
pontoon copied to clipboard

Add Entity and Search pages

Open functionzz opened this issue 2 months ago • 5 comments

Creates 2 pages, one which conducts entity translation search, the other displays the entity with all translations. Inspired by the functionality of Tranvision.

functionzz avatar Oct 07 '25 15:10 functionzz

Codecov Report

:x: Patch coverage is 34.86239% with 71 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 78.46%. Comparing base (22aa0af) to head (9568466).

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Oct 07 '25 16:10 codecov-commenter

We have SITE_URL, but I'm not sure you mean that. Irrespective or respective? Exactly what I mean, thank you.

If the DRF endpoint is part of the same Django project, you don’t need to make an actual HTTP request — you can just invoke the view logic directly, which should be faster and doesn’t require the network stack.

You are 100% right

functionzz avatar Oct 08 '25 00:10 functionzz

Notes for styling:

  • translations_list.html, entity.html, entities_list.html, and search.html all require styling. Also, search.js houses a jQuery appended list, so classes need to be applied there.
  • All these files are currently skeletons, with data + a basic styling applied.
  • Core functionality is currently implemented

Remaining TODOs:

  • [ ] clipboard
  • [ ] replace url with /search instead of /new-search
  • [ ] have ENTER also submit a request for the /search page

functionzz avatar Oct 22 '25 19:10 functionzz

Remaining TODOs: * [ ] clipboard * [ ] replace url with /search instead of /new-search

The URL change sounds like a low hanging fruit, so I suggest just doing it.

Re clipboard: note that we already have it implemented in Machinery.

mathjazz avatar Oct 22 '25 19:10 mathjazz

Core functionality is currently implemented

As per the Slack "spec" we're missing the source string metadata on the entity page, as well as the Link to translate view.

mathjazz avatar Oct 22 '25 20:10 mathjazz