pontoon icon indicating copy to clipboard operation
pontoon copied to clipboard

No warnings when trying to submit empty translations

Open flodolo opened this issue 3 years ago • 5 comments

I've noticed an increase in the number of empty strings in Firefox, where I have special checks.

Apparently, we don't warn anymore when someone tries to submit an empty translation.

flodolo avatar Aug 09 '22 13:08 flodolo

Is that Fluent specific? We should submit { "" } as an empty translation, which was indeed introduced recently.

Is that not the case? What is the expectation?

mathjazz avatar Aug 09 '22 15:08 mathjazz

The expectation is to get a warning, not submit directly. Wasn't that the case before?

flodolo avatar Aug 09 '22 15:08 flodolo

I think we prevented submission completely, because the actual empty string was being submitted, which is an error in Fluent.

mathjazz avatar Aug 09 '22 15:08 mathjazz

Note: this is starting to impact other Fluent projects, so it's clear to me that we changed the behavior.

flodolo avatar Aug 15 '22 11:08 flodolo

Starting to properly look at this. The proximate cause of this is the way that we no longer construct broken Fluent messages for empty content, so solving the issue will likely require a compare-locales update.

eemeli avatar Sep 20 '22 14:09 eemeli