pontoon icon indicating copy to clipboard operation
pontoon copied to clipboard

Enforce critical checks on PO files

Open mathjazz opened this issue 3 years ago • 3 comments

We currently don't enforce any checks on PO files, which means pop-up warnings can be bypassed, and errors & warnings are never stored into the DB. We also don't run any checks on PO files on sync, file upload or submission through batch actions, which causes problems.

The reason for not using checks on PO files is that the library we use yields lots of false positives. We should first see if limiting checks to only the CRITICAL category is more reliable and maybe even consider dropping some checks (in particular from the COSMETIC category).

We could also investigate if we can leverage dennis for this purpose, which some Mozilla apps use to prevent bad translations from causing errors in production.

mathjazz avatar Mar 09 '22 13:03 mathjazz

Thanks for filing the issue.

peiying2 avatar Mar 09 '22 18:03 peiying2

The reason for not using checks on PO files is that the library we use yields lots of false positives.

For example, see #3012.

mathjazz avatar Nov 07 '23 21:11 mathjazz

Another example (reported by Itiel in #pontoon): While translating this string, I get "Options" check warning: https://pontoon.mozilla.org/he/amo-frontend/all-resources/?string=286844

mathjazz avatar Nov 07 '23 21:11 mathjazz