Perform search on filtered translations only

[bugzilla-to-github]

This issue was created automatically by a script.

Bug 1399839

Bug Reporter: @TheoChevalier CC: [email protected], @flodolo, @mathjazz, @jotes

Right now when performing a search, it provides matches from:

• The source string
• The approved translation
• Any pending or rejected suggestion
• Localization notes
• The string name (and probably full path)

I would like to be able to perform a search on the approved translations only, to reduce the number of false positives.

It would be particularly useful when performing searches related to punctuation mistakes, but there are other type of searches where it would help, like for words similar in English and the target language

[bugzilla-to-github]

Comment Author: @TheoChevalier

To clarify, I don’t suggest to alter the default search settings, but adding an option to only search in approved translations.

[bugzilla-to-github]

Comment Author: @jotes

:tchevalier So, basically that filter should affect only search results. This sounds like the advanced settings for search - am I correct?

[bugzilla-to-github]

Comment Author: @TheoChevalier

(In reply to jotes from comment #2)

:tchevalier So, basically that filter should affect only search results. This sounds like the advanced settings for search - am I correct?

Yes, that would be the idea

[bugzilla-to-github]

Comment Author: @mathjazz

Thanks for the suggestion, Théo!

I wonder if Approved translations are a special case here, or would one sometimes also want to search within other groups of strings, e.g. Fuzzy or Rejected.

If the latter, we could change the default search behaviour when filters are applied. If you filter Translated, we only search Translated, if you filter Untranslated, we only search Untranslated, etc. One benefit of this approach is that we don't need to add complexity to the UI.

[bugzilla-to-github]

Comment Author: @TheoChevalier

(In reply to Matjaz Horvat [:mathjazz] from comment #4)

Thanks for the suggestion, Théo!

I wonder if Approved translations are a special case here, or would one sometimes also want to search within other groups of strings, e.g. Fuzzy or Rejected.

If the latter, we could change the default search behaviour when filters are applied. If you filter Translated, we only search Translated, if you filter Untranslated, we only search Untranslated, etc. One benefit of this approach is that we don't need to add complexity to the UI.

I like the idea of matching with filters, that would be even better than my initial suggestion.

[bugzilla-to-github]

Comment Author: Djfe <[email protected]>

Isn't this implemented by now? Or am I missing something?

[bugzilla-to-github]

Comment Author: @flodolo

(In reply to Djfe from comment #6)

Isn't this implemented by now? Or am I missing something?

No. If you filter by "Translated" and search, it still searches in source string, comment, suggestions, string ID within this group of strings.

[MarceloGhelman]

Hi there, Any plans to implement this @TheoChevalier request? It would be very helpful for reviewers. The implementation suggestion from @mathjazz is excellent.