normandy icon indicating copy to clipboard operation
normandy copied to clipboard

Recipe actions should not be editable after a recipe is created

Open Osmose opened this issue 8 years ago • 5 comments
trafficstars

#599, #584 and #586 all involve adding server-side behavior that is custom to a specific type of action, and there's potentially confusing edge cases for recipes that change their action. I can't think of a compelling reason to allow users to edit the recipe action after a recipe has been created anyway; they should just create a brand new recipe instead.

@MattGrimes @gregglind @mythmon Thoughts? Objections?

Osmose avatar Mar 09 '17 00:03 Osmose

This isn't something we need for preference experiments.

mythmon avatar Mar 28 '17 22:03 mythmon

This is a pretty simple one-liner to implement*. The only question I have is could the user change the action when cloning? Pending this feature's approval, this should be a quick fix.

*<ActionSelect disabled={isLoading || recipe.getIn(['action', 'id'])} />

andymikulski avatar Aug 07 '17 19:08 andymikulski

  1. I think cloning should be able to change the action.
  2. In a separate PR from the proposed change, I think we want to disallow this on the server side as well as on the client. The eventual goal is to modify our data model to make per-action customization easy.

Osmose avatar Aug 14 '17 19:08 Osmose

+1 to osmose

MattGrimes avatar Oct 03 '17 17:10 MattGrimes

I think this is both a front-end and back-end issue. The UI should be nice and not expose changing the action after the recipe is created, but also the backend shouldn't allow it, even if the UI does.

mythmon avatar Feb 21 '18 21:02 mythmon