Fix build for removal of firefox-{beta,devedition}-bin from nixpkgs

[andersk]

• https://github.com/NixOS/nixpkgs/pull/414510

This has an unfortunate side effect of renaming the firefox-beta, firefox-devedition, firefox-nightly binaries to firefox on affected nixpkgs versions.

[dtomvan]

Also, I think the channel argument (set here) is invalid as of https://github.com/NixOS/nixpkgs/commit/5c44b02d95616376992513d02756104b311cf4cb:

nix-repl> :lf github:mozilla/nixpkgs-mozilla
Added 12 variables.

nix-repl> pkgs = import <nixpkgs> { overlays = [ outputs.overlay ]; }

nix-repl> pkgs.latest.firefox-nightly-bin
error:
       … in the condition of the assert statement
         at /nix/store/ny8c07vsrfwcb1c4i3jcpbi3qi4w9wy6-source/lib/customisation.nix:419:9:
          418|       drvPath =
          419|         assert condition;
             |         ^
          420|         drv.drvPath;

       … while evaluating a branch condition
         at /nix/store/ny8c07vsrfwcb1c4i3jcpbi3qi4w9wy6-source/pkgs/stdenv/generic/check-meta.nix:646:5:
          645|     in
          646|     if validity ? handled then
             |     ^
          647|       validity

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: function 'anonymous lambda' called with unexpected argument 'channel'
       at /nix/store/ny8c07vsrfwcb1c4i3jcpbi3qi4w9wy6-source/pkgs/applications/networking/browsers/firefox-bin/default.nix:1:1:
            1| {
             | ^
            2|   lib,

[andersk]

That’s not “also”, that’s the whole point of my PR. But it was removed in the commit I linked, not the one you linked (yours is just the update script).

[dtomvan]

Sorry, I misinterpreted the diff. I assumed channel = version.channel; should've been removed, but I see you did it conditionally. Sorry for being overly confident in my suggestion. I don't know enough of the nixpkgs lib yet so I falsely assumed your patch did not do what I want...

[anna328p]

Any updates?