nixpkgs-mozilla icon indicating copy to clipboard operation
nixpkgs-mozilla copied to clipboard
verified publisher icon mozilla

rust-overlay: restore SYSROOT detection for Darwin

Open ggreif opened this issue 2 years ago • 6 comments

f6fe8508b0910b84b74c0e0bfa0ff8593e77d470 broke Darwin (fixes #304). This PR:

  • removes rm before cp (and uses --remove-destination instead)
  • copies librustc_driver-*.dylib too

Takes some cues from #306 (and supersedes it).

ggreif avatar Apr 25 '23 23:04 ggreif

Bump for attention.

AliSajid avatar Jun 02 '23 17:06 AliSajid

Bump for attention.

Unfortunately, this does not work this way … You can always ping me on https://matrix.to/#/#mozilla:nixos.org .

nbp avatar Jun 26 '23 09:06 nbp

Looks like #304 has fixed this, so closing for now.

ggreif avatar Jul 28 '23 16:07 ggreif

Unfortunately .dylibs are not considered in #304 yet, so reopening.

ggreif avatar Jul 31 '23 19:07 ggreif

@AliSajid I am using this branch as pull/309/head and it works for both Linux and Darwin in our setup.

ggreif avatar Aug 01 '23 15:08 ggreif

@Artturin @nbp This is now a very mild delta, any chance to review?

ggreif avatar Aug 11 '23 10:08 ggreif