neqo icon indicating copy to clipboard operation
neqo copied to clipboard

Meta: Implement all qlog probes

Open agrover opened this issue 4 years ago • 3 comments

Once basic qlog support lands in Neqo (#526), we still need to add probes for all the things qlog can log. These should be relatively straightforward, and can likely be done as a group effort.

The below list is all event types supported by the qlog crate, version 0.2. Future versions of the qlog specification and the qlog crate may change this list. qlog supports "min" versions of many event constructors, which contain only the most commonly relevant fields of the event. Either version may be used.

  • [x] congestion_state_updated(_min)
  • [ ] connection_id_updated(_min)
  • [x] connection_started(_min)
  • [ ] connection_state_updated(_min)
  • [ ] datagram_dropped(_min)
  • [ ] datagrams_received(_min)
  • [ ] datagrams_sent(_min)
  • [ ] frames_processed
  • [x] h3_data_moved(_min)
  • [ ] h3_frame_created(_min)
  • [ ] h3_frame_parsed(_min)
  • [ ] h3_parameters_set(_min)
  • [ ] h3_push_resolved(_min)
  • [ ] h3_stream_type_set(_min)
  • [ ] loss_timer_set(_min)
  • [ ] marked_for_retransmit
  • [x] metrics_updated(_min)
  • [ ] packet_buffered
  • [x] packet_dropped(_min)
  • [x] packet_lost(_min)
  • [x] packet_received(_min)
  • [x] packet_sent(_min)
  • [ ] qpack_dynamic_table_updated
  • [ ] qpack_headers_decoded(_min)
  • [ ] qpack_headers_encoded(_min)
  • [x] qpack_instruction_received(_min) (partial)
  • [ ] qpack_instruction_sent(_min)
  • [ ] qpack_state_updated(_min)
  • [ ] qpack_stream_state_updated
  • [ ] recovery_parameters_set(_min)
  • [ ] server_listening(_min)
  • [ ] ~~spinbit_updated~~ (Neqo does not implement spin bit)
  • [ ] stream_state_updated(_min)
  • [x] transport_parameters_set(_min)

agrover avatar Apr 07 '20 20:04 agrover

Nice to have but implementing all of this is not critical.

agrover avatar Jul 28 '20 00:07 agrover

Hello, I'm new to QUIC. May I contribute to some of these tasks while trying to catch up?

yuyawk avatar Oct 10 '21 18:10 yuyawk

@yuyawk, I would suggest that you pick something that you think might be useful and try to build it. Maybe I can suggest that you open an issue to track it. Just reference this issue in the text so that we can track it. If you are having trouble, use that issue to ask any questions you might have.

martinthomson avatar Oct 11 '21 00:10 martinthomson