neqo icon indicating copy to clipboard operation
neqo copied to clipboard

Cut down on epic tests

Open agrover opened this issue 4 years ago • 4 comments

In addition to needing more tests, the tests we have are each too big, testing multiple things rather than each testing one aspect of functionality.

These should be broken up into finer-grained tests.

agrover avatar Mar 17 '20 00:03 agrover

This work is well-suited to first-time contributors, since it just involves finding a long multipart test, breaking it up, and then making sure tests pass and are roughly equivalent. There are multiple of these, so this work should be parallelizable. Of course, existing contributors should also find time to help in this effort.

(This is also a good way to discover aspects of behavior that are NOT covered by our current tests, and maybe add them :smiley: )

agrover avatar Mar 17 '20 00:03 agrover

@agrover , which one is better to start with? Thanks

undef1nd avatar Mar 18 '20 15:03 undef1nd

@undef1nd I'd look in neqo-transport for one that is 1) big and 2) you understand what it is testing. Maybe it even has comments 3) is testing more than one aspect of behavior. Then, try to see if you can split it into tests that are smaller.

In fact, there are fresh examples in send_stream.rs for next_bytes(), maybe that could be a starting spot.

agrover avatar Mar 18 '20 17:03 agrover

@agrover , got it, thanks, will have a closer look over the weekend then.

undef1nd avatar Mar 18 '20 18:03 undef1nd