neqo icon indicating copy to clipboard operation
neqo copied to clipboard
verified publisher icon mozilla

`hrtime::test::update_multi` fails occasionally in CI on Ubuntu

Open larseggert opened this issue 10 months ago • 1 comments

Debug and fix or disable.

larseggert avatar Feb 05 '25 12:02 larseggert

Mostly on the new arm64 runners it seems.

larseggert avatar Feb 06 '25 11:02 larseggert

I thought I had fixed that in #2636 but I guess not.

larseggert avatar May 16 '25 17:05 larseggert

https://github.com/mozilla/neqo/pull/2636 disables the test on ARM.

https://github.com/mozilla/neqo/actions/runs/15073341987/job/42374916088?pr=2639 is a recent failure on x86-64.

mxinden avatar May 16 '25 17:05 mxinden

https://github.com/mozilla/neqo/actions/runs/15073341987/job/42374916088?pr=2639#step:7:291

martinthomson avatar May 19 '25 02:05 martinthomson

Probably fixed by #2641

larseggert avatar May 20 '25 05:05 larseggert

Reopening again, given recent failure:

https://github.com/mozilla/neqo/actions/runs/15418677161/job/43387638309?pr=2691

mxinden avatar Jun 03 '25 13:06 mxinden

Another: https://github.com/mozilla/neqo/actions/runs/15485123773/job/43598054549

larseggert avatar Jun 06 '25 08:06 larseggert

Two more:

  • https://github.com/mozilla/neqo/actions/runs/15528951618/job/43713676263?pr=2717
  • https://github.com/mozilla/neqo/actions/runs/15528951618/job/43713676248?pr=2717

@martinthomson is there anything we can tweak, or should we disable this test on ubuntu-24.04-arm?

larseggert avatar Jun 09 '25 08:06 larseggert

The slack we allow for timers is 1.5ms. Here, I'm seeing up to twice that amount of slip for ARM. We could have different constants for the different platforms, to allow for increased slippage on ARM.

martinthomson avatar Jun 10 '25 12:06 martinthomson