multi-account-containers icon indicating copy to clipboard operation
multi-account-containers copied to clipboard

Extension opens a new tab when an "Always Open in This Container" domain is opened in a different container for activity stream

Open cpeterso opened this issue 7 years ago • 16 comments

If I pin a domain to a container (using the "Always Open in This Container" context menu item) and then open that domain in a tab within a different container (or even about:newtab with no container), Firefox opens a new tab for the new container and domain. This is frustrating because I lose my context when the new tab opens and I also have to manually close the old tab. Is it possible for the current tab to instead switch containers when the new domain is opened?

I uninstalled and reinstalled the Containers extension so it would forget all my domain/container settings. The current implementation of "Always Open in This Container" is just too frustrating. I will just open containers manually for now.

cpeterso avatar Apr 10 '17 04:04 cpeterso

Some of the tab switching issues were solved with: #436 which is yet to launch, probably tomorrow.

However we will always need to open a new tab for a different container, this is a limitation of the platform itself which @bakulf might be able to talk more about.

Specifically managing back and forwards between links in the same tab would have to throw away and reattach the container and there are likely History and referrer leaks that we want to prevent here too.

We open the tab to the right of the current website, given the limitation of the platform there isn't much else we can do to make this neater is there?

jonathanKingston avatar Apr 10 '17 12:04 jonathanKingston

Assigning @bakulf to add a comment about the platform restrictions and address if we can fix ever? (it's not going to be within this experiment certainly though)

jonathanKingston avatar Apr 10 '17 12:04 jonathanKingston

I think 80% of my personal annoyance could be solved by auto-closing the previous tab if it was about:newtab (and maybe checking that the about:newtab tab had no back history). I frequently open a new tab, enter a domain name using auto-complete, then Firefox opens a new tab in the correct container and I manually close the about:newtab tab. :)

cpeterso avatar Apr 11 '17 02:04 cpeterso

It does auto-close if it's about:newtab? Crawling history is a little ugly but we could add that if we are closing tabs that shouldn't exist.

This sounds like a bug then as it should close:

  • about:startpage
  • about:newtab
  • about:home
  • about:blank

Do you have an extension changing the default URL perhaps or preventing that being closed?

jonathanKingston avatar Apr 11 '17 02:04 jonathanKingston

And you can verify you're on the latest 2.1.2 version of the add-on?

groovecoder avatar Apr 11 '17 12:04 groovecoder

Do you have an extension changing the default URL perhaps or preventing that being closed?

Actually, yes! :) I have the Activity Stream Test Pilot extension installed. If I disable the Activity Stream extension, then Containers extension closes about:newtab/etc correctly as you describe. I'll keep Activity Stream disabled for now.

btw, I am running version 2.1.2.

cpeterso avatar Apr 11 '17 16:04 cpeterso

Did I just hear that you prefer Containers more than Activity Stream? 😜

groovecoder avatar Apr 11 '17 16:04 groovecoder

I need Containers to effectively use my multiple Google accounts. I can live without a fancy about:newtab. 😀

cpeterso avatar Apr 11 '17 22:04 cpeterso

Woot woot test pilot rivalry 😂. But yeah this is maybe fixable as it might just be a different URL.

On Tue, 11 Apr 2017, 23:04 Chris Peterson, [email protected] wrote:

I need Containers to effectively use my multiple Google accounts. I can live without a fancy about:newtab. 😀

— You are receiving this because you were assigned.

Reply to this email directly, view it on GitHub https://github.com/mozilla/testpilot-containers/issues/441#issuecomment-293414147, or mute the thread https://github.com/notifications/unsubscribe-auth/AAUsLAT7pPYjZI6rr1geVX0vt4adXGkHks5ru_kJgaJpZM4M4TQB .

jonathanKingston avatar Apr 11 '17 22:04 jonathanKingston

Activity Stream's new tab URL is resource://activity-streams/data/content/activity-streams.html#/

cpeterso avatar Apr 12 '17 16:04 cpeterso

Has anyone picked up this issue?

olsenme avatar Oct 03 '19 16:10 olsenme

@cpeterso

olsenme avatar Oct 03 '19 16:10 olsenme

I am an outreachy applicant

olsenme avatar Oct 03 '19 16:10 olsenme

@olsenme Yes! All yours.

maxxcrawford avatar Oct 03 '19 16:10 maxxcrawford

@maxxcrawford sorry it's taken me so long to get going on this. So, you guys are using the fork, branch, and pr workflow correct? That's what I picked up from your readMe

olsenme avatar Oct 10 '19 17:10 olsenme

https://github.com/mozilla/multi-account-containers/issues/441#issuecomment-293632989

resource://activity-streams/data/content/activity-streams.html#/

Not effective for me with Firefox 88.

grahamperrin avatar Apr 30 '21 04:04 grahamperrin