multi-account-containers icon indicating copy to clipboard operation
multi-account-containers copied to clipboard

adds an ability to reopen current tab in the specific container with a shortcut

Open antondudakov opened this issue 9 months ago • 1 comments

Before submitting your pull request

  • [x] I agree to license my code under the MPL 2.0 license.
  • [x] I rebased my work on top of the main branch.
  • [x] I ran npm test and all tests passed.
  • [x] I added test coverages if relevant.

Description

Issue https://github.com/mozilla/multi-account-containers/issues/1792

Type of change

Select all that apply.

  • [ ] Bug fix
  • [x] New feature
  • [ ] Major change (fix or feature that would cause existing functionality to work differently than in the current version)
Screenshot 2025-02-21 at 2 54 37 PM

https://github.com/user-attachments/assets/4291315b-d808-4bcf-92eb-e31511614c25

PR to localization: https://github.com/mozilla-l10n/multi-account-containers-l10n/pull/31

antondudakov avatar Feb 21 '25 12:02 antondudakov

Hey, guys. Can I have a review, please? @dannycolin @groovecoder @rafeerahman

antondudakov avatar Apr 20 '25 10:04 antondudakov

Hey, guys. Can I have a review, please? @dannycolin @groovecoder @rafeerahman

😭😭😭 Can we have this?

antondudakov avatar Jul 14 '25 12:07 antondudakov

Hey, guys. Can I have a review, please? @dannycolin @groovecoder @rafeerahman

😭😭😭 Can we have this?

@lesleyjanenorton

antondudakov avatar Jul 14 '25 13:07 antondudakov

Hey, guys. Can I have a review, please? @dannycolin @groovecoder @rafeerahman

😭😭😭 Can we have this?

@lesleyjanenorton

@antondudakov this is open source and sometimes people just have no time to pay attentions because completely overloaded on their regular job.

What I could advise to increase chances for faster review and acceptance of PR:

  • implement only functionality that you would like to get: less code to review - easier to review and bigger chance to be reviewed.
  • if you would like to have code refactored - create separate PR: less code to review and with no new functionality - easier to review and bigger chance to be reviewed.
  • create a GitHub Issue that will describe what is the feature and how it will work, sometimes discussion in the issue result to completely different direction of feature implementation than initially it was expected.

achernyakevich-sc avatar Jul 14 '25 14:07 achernyakevich-sc

Hey, guys. Can I have a review, please? @dannycolin @groovecoder @rafeerahman

😭😭😭 Can we have this?

@lesleyjanenorton

@antondudakov this is open source and sometimes people just have no time to pay attentions because completely overloaded on their regular job.

What I could advise to increase chances for faster review and acceptance of PR:

* implement only functionality that you would like to get: less code to review - easier to review and bigger chance to be reviewed.

* if you would like to have code refactored - create separate PR: less code to review and with no new functionality - easier to review and bigger chance to be reviewed.

* create a GitHub Issue that will describe what is the feature and how it will work, sometimes discussion in the issue result to completely different direction of feature implementation than initially it was expected.

This is exactly what I did.

  1. The code that implement feature is just around 50 lines of code;
  2. it's not a refactoring;
  3. There's an issue https://github.com/mozilla/multi-account-containers/issues/1792, I also mentioned my PR in comments in the issue

antondudakov avatar Jul 14 '25 16:07 antondudakov

Hey @achernyakevich-sc, I hope you're doing well. Could you provide a review, please? I've addressed all your comments. 🙏🥹

antondudakov avatar Aug 01 '25 06:08 antondudakov

@achernyakevich-sc, if you have a spare minute, please review. All addressed

antondudakov avatar Aug 25 '25 09:08 antondudakov

Hey, @bakulf, can you give feedback on this PR as well? I would really appreciate it.

antondudakov avatar Oct 01 '25 12:10 antondudakov