mozregression icon indicating copy to clipboard operation
mozregression copied to clipboard

Handle initial ranges that start and end on the same day

Open mathewhodson opened this issue 4 years ago • 2 comments

mathewhodson avatar Apr 16 '22 02:04 mathewhodson

Coverage Status

Coverage decreased (-0.04%) to 91.181% when pulling aa944538752a247eff9ce12858425b681ed52067 on mathewhodson:buildid into d9796770fc6c914fb957f3fade221f64e4107570 on mozilla:main.

coveralls avatar Apr 16 '22 02:04 coveralls

@zzzeid Do you have a chance to review this?

mathewhodson avatar Aug 01 '22 22:08 mathewhodson

@zzzeid Do you have a chance to review this?

Hi @mathewhodson -- any chance you can rebase with main and re-run the test suite? It would also be great if you can add to the description what the current behaviour is (i.e. STR) since there is no bug associated with this PR.

zzzeid avatar Sep 21 '22 16:09 zzzeid

This fixes commands like .\mozregression -g 20220413094328 -b 20220413215253 that would previously fail with something like this:

INFO: Got as far as we can go bisecting nightlies...
INFO: Last good revision: 4ddd4f1a1b2758a33b531378b2f011c3063fed1a (2022-04-13 21:52:53)
INFO: First bad revision: 4ddd4f1a1b2758a33b531378b2f011c3063fed1a (2022-04-13 21:52:53)
[...]
ERROR: The url
'https://hg.mozilla.org/mozilla-central/json-pushes?fromchange=4ddd4f1a1b2758a33b531378b2f011c3063fed1a&tochange=4ddd4f1a1b2758a33b531378b2f011c3063fed1a'
contains no pushlog. Maybe use another range ?

mathewhodson avatar Sep 21 '22 21:09 mathewhodson

Thanks for the merge

mathewhodson avatar Nov 01 '22 23:11 mathewhodson