hubs
hubs copied to clipboard
Allow newlines in troika-text
With the switch to troika text, we lost processing of newline characters in text values.
Troika's docs said they support them, so I took a peek at their source and found this little preprocessing on the text value was not present in the hubs version.
Ah interesting, I wonder why the string is ending up with a literal ['\' 'n']
instead of a newline character. I guess you just cant type actual newlines in to the HTML (would probably work via setAttribute
. Could try
. In anycase this change seems sane enough.
@netpro2k oh yeah I should have specified it's not literal new lines, but <a-entity text="value: line 1\nline 2"></a-entity>
that is affected
This looks ok to me, @netpro2k do you see any issues with pulling this in?
@matthewbcool thanks for following up. I expect this PR is obsolete with the refactor away from A-Frame underway