hubs icon indicating copy to clipboard operation
hubs copied to clipboard

[VR] The PDF pages are not turned

Open Softvision-RemusDranca opened this issue 3 years ago • 5 comments

[Affected Versions]:

  • Oculus Browser

[Affected Platforms]:

  • Oculus Quest

[Prerequisites]:

  • Your Hubs Cloud stack is set up.
  • Have a room opened.

[Steps to reproduce]:

  1. Import a PDF file into the room.
  2. Change the PDF pages and observe the behavior.

[Expected results]:

  • The pages are turned.

[Actual results]:

  • The pages number is changed but the file remains on the same page.

[Notes]:

  • This issue is reproducible when trying to change to the previous or next page.

┆Issue is synchronized with this Jira Task

Softvision-RemusDranca avatar Dec 15 '21 13:12 Softvision-RemusDranca

FYI the exact same issue I believe was reported to A-Frame repo https://github.com/aframevr/aframe/issues/4984 And #4181 may be related to this too.

vincentfretin avatar Jan 08 '22 16:01 vincentfretin

#3968 may be related to this issue.

vincentfretin avatar Jan 08 '22 16:01 vincentfretin

It seems that this is caused by functions added to window.requestAnimationFrame not beeing called anymore because the window is not redrawn in vr. This is however used by PDFjs to render the pdfs and resolve the page.render() promise in src/components/media-pdf.js The PR #5427 proposes a possible solution.

CodingBitsDev avatar May 12 '22 13:05 CodingBitsDev

If we can implement a fix to this fairly quickly we should do this as P1, we may downgrade this to P2 if it requires a deeper dive.

emclaren avatar May 25 '22 20:05 emclaren

Hello, this bug is really annoying because PDFs are widely used for VR. Is there any news concerning the progress of the correction of this bug?

Dayk0 avatar Sep 05 '22 12:09 Dayk0

I will add myself into this thread because this bug is still as February 2023 present. In Hubs Cloud as well as the official Mozilla Hubs instances have this bug. It happens also on all VR devices so it doesnt depend which VR device is used.

I hope this bug fix will be taken faster in consideration as multiple clients as well as users cant use the PDF tool, which is very important especially if its used for introduction to the virtual room itself as well as to display controls and usability. So most users are still hanging on the very first steps in the experience.

yasienkashef avatar Feb 17 '23 03:02 yasienkashef

The proposed fix above solves the problem. It is currently uses aframe systems but that can be easily adapted to bitECS.

CodingBitsDev avatar Feb 17 '23 08:02 CodingBitsDev

It seems that this is caused by functions added to window.requestAnimationFrame not beeing called anymore because the window is not redrawn in vr. This is however used by PDFjs to render the pdfs and resolve the page.render() promise in src/components/media-pdf.js The PR #5427 proposes a possible solution.

Thank you! This helped me on a similar project. I very much appreciate the share 🙏

PlumCantaloupe avatar Feb 23 '23 17:02 PlumCantaloupe