fxa-content-server icon indicating copy to clipboard operation
fxa-content-server copied to clipboard

style(signup): improve styling of password advice

Open lmorchard opened this issue 6 years ago • 7 comments

Fixes #6448

lmorchard avatar Mar 12 '19 19:03 lmorchard

This PR doesn't include the second bubble for the repeat password field. But, if that's a must for this issue, I can close this and go back to the drawing board for a bit.

lmorchard avatar Mar 12 '19 19:03 lmorchard

Aesthetically, this looks great!

But, if that's a must for this issue, I can close this and go back to the drawing board for a bit.

Both @davismtl and @ryanfeeley want the 2nd bubble there before removing the text from the first bubble so that the user is informed why the password is important.

shane-tomlinson avatar Mar 13 '19 12:03 shane-tomlinson

Alrighty, let's call this WIP then and I'll get to work on the 2nd bubble today

lmorchard avatar Mar 13 '19 18:03 lmorchard

I've stumbled my way toward having both bubbles, but a) not entirely sure the behavior is correct and b) I need to explore adding tests

lmorchard avatar Mar 15 '19 21:03 lmorchard

Okay, going to call this no longer in-progress: Got the second bubble added, along with tests. Could use some input on whether the UX is appropriate, etc.

lmorchard avatar Mar 19 '19 19:03 lmorchard

Oh yeah, and... @ryanfeeley / @shane-tomlinson - r?

I kind of guessed at UX tweaks around hiding the bubbles when the fields lose focus. And I think the view code is the right shape, but I was a little confused about FormView being used for a field rather than a whole form,

lmorchard avatar Mar 20 '19 15:03 lmorchard

This repo has been deprecated and migrated to https://github.com/mozill/fxa. Please open this PR against that repo.

shane-tomlinson avatar Apr 03 '19 06:04 shane-tomlinson