fx-private-relay-add-on icon indicating copy to clipboard operation
fx-private-relay-add-on copied to clipboard

Reduced `z-index` on email field wrapper

Open reemhamz opened this issue 2 years ago • 4 comments

Problem

Users who had Relay enabled experienced issues of having the email input field stacking on top of almost any other element on the page. Here's an example: Screen Shot 2022-06-13 at 3 42 36 PM

Original issue

https://github.com/mozilla/fx-private-relay-add-on/issues/22

My solution

With this fix, I mainly just reduced the z-index from 9999999999999.... to a 10. I tested this out and this is the result: Screen Shot 2022-06-23 at 11 54 10 AM

Maybe this needs more testing, but the issue has been up for some years with no action, so thought I'd take a swing at it. I'm sure there was a reason the z-index was so high in the first place.

reemhamz avatar Jun 23 '22 01:06 reemhamz

I feel like this shouldn't be merged and we need an actual solution for this issue. It's still going to present the same problem for websites that use a z-index under 10 for other things.

lolrepeatlol avatar Jun 23 '22 03:06 lolrepeatlol

Yeah, it's not necessarily the most inventive solution. However this issue has been around for some years and I mainly wanted to bring eyes to the matter. I think this is a good start compared to its initial z-index value of 99999999...99..9

reemhamz avatar Jun 23 '22 03:06 reemhamz

This definitely is a known issue.

It would make sense to do some sort of CSS query/lookup to see if there's already a set z-index value.

I'll share this with the team! Thanks for taking a whack at this.

maxxcrawford avatar Jun 23 '22 11:06 maxxcrawford

No : this not fix the issue : there are no reason to have a z-index.

This not fix the issue in mybb foruml when search for an user

Capture d’écran du 2022-09-22 15-09-41 With z-index to 10.

Removing the z-index is a lot more a better fix : https://github.com/mozilla/fx-private-relay/pull/632

Shnoulle avatar Sep 22 '22 13:09 Shnoulle

I believe this was superseded by #462

janbrasna avatar Apr 22 '24 11:04 janbrasna

Thank you @janbrasna, that is correct!

Vinnl avatar Apr 23 '24 10:04 Vinnl