fx-private-relay-add-on icon indicating copy to clipboard operation
fx-private-relay-add-on copied to clipboard
verified publisher icon mozilla

[Addon] The door-hanger does not respect the dark theme

Open sbadau opened this issue 5 years ago • 4 comments

Affected versions Firefox 76.0.1 Private Relay add-on version 1.4.0

Affected platforms Windows 10 Mac OS X 10.14 Ubuntu 18.04

Steps to reproduce:

  1. Launch Firefox.
  2. Enable the dark theme: Add-ons Manager -> Themes section -> Enable the Dark theme
  3. Install the Private Relay add-on
  4. In the Adress bar - click on the Private Relay add-on
  5. Observe the Firefox Private Relay door-hanger.

Expected behavior The Firefox Private Relay door-hanger should be dark.

Actual behavior The Firefox Private Relay door-hanger is white - does not respect the dark theme.

Please see the screencast for more details:

darktheme

sbadau avatar May 22 '20 14:05 sbadau

I can reproduce this issue also on the button's door-hanger - neither one of them are respecting the dark theme.

2020-06-17_18h40_18

sbadau avatar Jun 17 '20 15:06 sbadau

I'd be interested to help implementing this feature. I've already done similar patches for Multi-Account Containers.

dannycolin avatar Mar 28 '22 00:03 dannycolin

@dannycolin Let me discuss this with the team. Our website itself does not support night mode. We may need some additional assets.

Additionally, we're about to land a large refactor of the add-on UI.

Please let me confirm before you dive in! Thanks!

maxxcrawford avatar Mar 29 '22 02:03 maxxcrawford

Please let me confirm before you dive in!

No problem. Feel free to ping me here or directly on Slack ;)

dannycolin avatar Mar 29 '22 12:03 dannycolin