firefox-translations icon indicating copy to clipboard operation
firefox-translations copied to clipboard

Translate the title of the page

Open martinthomson opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe. I notice that the title of the page is not translated.

Describe the solution you'd like The text of the page title could be translated in place.

Describe alternatives you've considered There is no easy way to indicate potential translation errors in a title, but it is still probably worth finding some way to do that, even if it is just on a tooltip.

Additional context n/a

martinthomson avatar Aug 26 '22 00:08 martinthomson

Hey @martinthomson, the title of the page is not translated only when the options to display errors is selected. Could you please confirm if you can see it translated when that option is unselected?

andrenatal avatar Sep 08 '22 16:09 andrenatal

Ah, that's very surprising. As you say, if you turn that option off, the title is translated.

That is surprising enough that I still regard this as a bug, rather than something intentional.

martinthomson avatar Sep 08 '22 23:09 martinthomson

I agree, it's a bug. It should translate the title as well, even though there is no way to communicate translation quality in the title.

Technically we can just implement it by stripping the tags added by quality estimation before we replace the title. The InPageTranslation class should be aware that it is not allowed to add anything but text to the <title> element.

jelmervdl avatar Sep 09 '22 07:09 jelmervdl