firefox-translations-training icon indicating copy to clipboard operation
firefox-translations-training copied to clipboard

Published 20 hours ago • verified publisher icon mozilla

Close resources in alignments for each step

Open gregtatum opened this issue 8 months ago • 0 comments

I was debugging alignment failures, and noticed that file handles are only closed at the end of the script running. It would be better to close things after each step is run. I also expanded the docs a bit more. For the review I would recommend hiding whitespace changes, as a lot of indentation changed.

screenshot of the hide whitespace widget

This PR is lower priority, and doesn't fix anything in the current training run. It was just a drive-by as I was looking into the code.

gregtatum avatar Jun 03 '24 16:06 gregtatum