firefox-translations-training icon indicating copy to clipboard operation
firefox-translations-training copied to clipboard

Incompatible python version

Open AmitMY opened this issue 1 year ago • 1 comments

For bicleaner, you use https://github.com/mozilla/firefox-translations-training/blob/main/pipeline/bicleaner/download_pack.py#L93

def main(args: Optional[list[str]] = None) -> None:

which is not allowed in this environment, defined here to use python 3.7

Traceback (most recent call last): File "pipeline/bicleaner/download_pack.py", line 93, in def main(args: Optional[list[str]] = None) -> None: TypeError: 'type' object is not subscriptable

AmitMY avatar Jan 31 '24 13:01 AmitMY

Python 3.7 is end of life, we should bump at least to 3.8.

marco-c avatar Jan 31 '24 14:01 marco-c

We don't have any issues with our current workflows. The supported Python versions are specified in poetry config and Docker images:

https://github.com/mozilla/firefox-translations-training/blob/04e9e9cdc369cc8efdf080d57eef805a61d2c35e/pyproject.toml#L9

eu9ene avatar May 08 '24 23:05 eu9ene