firefox-translations-training icon indicating copy to clipboard operation
firefox-translations-training copied to clipboard

"Cancel all" action doesn't work

Open eu9ene opened this issue 1 year ago • 10 comments

I have to cancel tasks separately now.

Screenshot 2023-11-08 at 10 03 49 AM

eu9ene avatar Nov 08 '23 18:11 eu9ene

I get a different message: Screenshot 2024-01-12 at 13 03 41

gabrielBusta avatar Jan 12 '24 19:01 gabrielBusta

@jcristau and @gabrielBusta managed to fix the upstream issues in Taskgraph that were blocking this. I believe we now need to pick up the latest taskgraph version and apply https://github.com/taskcluster/taskgraph/commit/31e06092d5a4aa25e741885492ee7f7b270c5cc4 and https://github.com/taskcluster/taskgraph/pull/459 to the .taskcluster.yml here to fix this issue.

bhearsum avatar Feb 09 '24 11:02 bhearsum

And also a small update to ci-configuration like this

bhearsum avatar Feb 09 '24 12:02 bhearsum

Was this issue about the cancel-all action in general, or specifically on a PR?

jcristau avatar Feb 09 '24 13:02 jcristau

Was this issue about the cancel-all action in general, or specifically on a PR?

Ah, it was about the action overall, heh. Well, we want actions in PRs as well...but that work won't help here :man_facepalming:

bhearsum avatar Feb 09 '24 13:02 bhearsum

Made a small amount of progress here today. The y that is undefined is actually this taskGroup variable when you unminify it.

I know we've seen wonkiness trying to trigger actions from a group that was created by an action task - and I suspect that's what we're witnessing here as well.

bhearsum avatar Mar 19 '24 20:03 bhearsum

https://github.com/taskcluster/taskcluster/pull/6917 is expected to fix this. It may be a week or two before it hits the Firefox CI cluster.

bhearsum avatar Mar 20 '24 15:03 bhearsum

https://github.com/taskcluster/taskcluster/pull/6917 is expected to fix this. It may be a week or two before it hits the Firefox CI cluster.

This half fixed things. The action does now work, but it uncovered an issue with some data being propagated when doing these steps:

  • Go to decision task group
  • Initiate a Train action
  • Navigate to one of the Tasks created from it
  • Go to that task's group
  • Use "Cancel All" from there

For the moment, this can be worked around by refreshing the new task group before using "Cancel All". I intend to fix the UI to make this unnecessary though.

bhearsum avatar Mar 28 '24 19:03 bhearsum

I'm not sure if it's the same issue or not but I have to run cancel all action 2-3 times before I can see in UI that all the tasks are cancelled, especially if some of them are in a "pending" state.

eu9ene avatar Jun 27 '24 23:06 eu9ene

I'm not sure if it's the same issue or not but I have to run cancel all action 2-3 times before I can see in UI that all the tasks are cancelled, especially if some of them are in a "pending" state.

I'd be interested in seeing an example of this, if you have one handy. It wouldn't shock me if this is a UI issue that goes away after a refresh, but it's also possible there's some cancel requests failing or such.

bhearsum avatar Jun 28 '24 12:06 bhearsum