firefox-translations-training icon indicating copy to clipboard operation
firefox-translations-training copied to clipboard

Published 20 hours ago • verified publisher icon mozilla

Bug: `train.sh` does not respect `best-model` setting

Open AmitMY opened this issue 2 years ago • 0 comments

In the train file, we save the final model always to be the chrf model. https://github.com/mozilla/firefox-translations-training/blob/main/pipeline/train/train.sh#L53-L54

This makes it so the model has the wrong name.

The pipeline wants: https://github.com/mozilla/firefox-translations-training/blob/main/Snakefile#L433

/training/models/spoken-signed/spoken_to_signed/backward/final.model.npz.best-ce-mean-words.npz

But the file created is

/training/models/spoken-signed/spoken_to_signed/backward/final.model.npz.best-chrf.npz

And because the file has a bad name, the rest of the pipeline crashes.

AmitMY avatar Aug 31 '22 09:08 AmitMY