experimenter icon indicating copy to clipboard operation
experimenter copied to clipboard

Branches are not removed from a recipe after the “This is a rollout (single branch)” checkbox is enabled

Open data-sync-user opened this issue 2 years ago • 2 comments

[Prerequisites]:

  • Have an experiment draft with multiple branches ready for launch.

[Steps to reproduce]:

  1. Open the draft from prerequisites on the “Branches” page.
  2. Check the “This is a rollout (single branch)” checkbox.
  3. Click “Save and Continue”.
  4. Click the “Preview Recipe JSON” link from the sidebar.
  5. Observe the rollout branches.

[Expected result]:

  • The branches removed from the “Branches” section when the “This is a rollout (single branch)” checkbox is enabled are also removed from the recipe.

[Actual result]:

  • The branches removed from the “Branches” section when the “This is a rollout (single branch)” checkbox is enabled are not removed from the recipe.

[Notes]:

  • The issue is also reproducible if the additional branches were not already saved before the checkbox was enabled.

  • Attached is a recording of the issue.

!branches remain in recipe.gif|width=1171,height=859!

┆Issue is synchronized with this Jira Bug ┆Attachments: branches remain in recipe.gif

data-sync-user avatar Aug 23 '22 09:08 data-sync-user

➤ Elise Richards commented:

I think this should be resolved by https://mozilla-hub.atlassian.net/browse/EXP-2725 ( https://mozilla-hub.atlassian.net/browse/EXP-2725|smart-link )

data-sync-user avatar Aug 26 '22 17:08 data-sync-user

➤ Elise Richards commented:

This is kinda working. It seems like the new branches don’t “stick” to the preview json until the second time you hit save 🤔

data-sync-user avatar Aug 26 '22 20:08 data-sync-user

➤ Maria Heres commented:

I have verified that the issue is no longer reproducible. Branches are removed from the recipe after they have been removed by checking the “This is a rollout (single branch)” checkbox. Tested using Firefox Release 106.0.2 (Build ID: 20221025065831) on Windows 10.

data-sync-user avatar Nov 01 '22 13:11 data-sync-user