experimenter icon indicating copy to clipboard operation
experimenter copied to clipboard

Published 20 hours ago • verified publisher icon mozilla

Some green checkmarks from the “Overview” and “Audience” sections overlap the drop-down arrows

Open data-sync-user opened this issue 3 years ago • 2 comments

[Prerequisites]:

  • Have an experiment in draft view.

[Steps to reproduce]:

  1. Have the “Overview” section displayed.
  2. Go to the “Additional Links” subsection.
  3. Click on the first drop-down button and choose one of the options displayed.
  4. Click outside of the drop-down button.
  5. Observe the behavior.

[Expected result]:

  • The checkmark is displayed next to the drop-down arrow.

[Actual result]:

  • The checkmark overlaps the drop-down arrow.

[Notes]:

  • This issue is also reproducible in the “Create a new Experiment” section for the “Application” field and in the “Audience” section for the “Channel”, “Min Version”, “Max Version” and “Advanced Targeting” fields.

  • In some cases the green checkmark overlaps the text.

  • Attached are some print screens of the issue.

┆Issue is synchronized with this Jira Bug ┆Attachments: image 1.JPG | image 2.JPG | Image 3.JPG

data-sync-user avatar Jan 27 '22 13:01 data-sync-user

I would like to work on this.

sudarsan2k5 avatar Oct 06 '22 17:10 sudarsan2k5

@sudarsan2k5 I have already assigned you to https://github.com/mozilla/experimenter/issues/7575. Once that is finished (or if you would rather work on this instead) then you can pick this one up 😄

eliserichards avatar Oct 10 '22 16:10 eliserichards

image

This is still valid. You can see that Channel, Min Version, Max Version, and Advaned Targeting all need some extra padding between the green checkmark and the dropdown arrow.

eliserichards avatar Mar 07 '23 22:03 eliserichards

Hello @eliserichards Im a new outreachy applicant, id like to be assigned this task

Yass32 avatar Mar 09 '23 08:03 Yass32

@yashikakhurana thank you

Yass32 avatar Mar 11 '23 02:03 Yass32

Hi @yashikakhurana sorry but I'm having trouble finding the CSS file of that page, can you please help me out?

Yass32 avatar Mar 11 '23 12:03 Yass32

Hello, can this task be assigned to me. I have an idea of how to go about it. I need your greenlight @yashikakhurana

Sprof22 avatar Mar 12 '23 23:03 Sprof22

@yashikakhurana thanks. setting up the environment. Expect results shortly

Sprof22 avatar Mar 13 '23 23:03 Sprof22

@Sprof22 are you still working on this?

yashikakhurana avatar Mar 16 '23 16:03 yashikakhurana

I am having difficulty setting up this project. If it's not working by the close of day, I will unassign myself. Thanks for your patience

Sprof22 avatar Mar 17 '23 00:03 Sprof22

Hello @yashikakhurana ma'am, the changes I made in one of my recent PR's (this one) also address this issue, but I haven't included the advanced targeting input selector in that one . I can include it in that PR itself or I could work on the rest of the changes in different PR for this particular issue which will close this, please let me know what you think about this, thanks

Avi-88 avatar Mar 19 '23 17:03 Avi-88

@Avi-88 sure thank you, since they are very closely related, I would suggest making changes in the same and link issue in the same PR, thanks

yashikakhurana avatar Mar 20 '23 04:03 yashikakhurana