experimenter icon indicating copy to clipboard operation
experimenter copied to clipboard

DataPoint.has_bounds implementation correctness

Open freshstrangemusic opened this issue 4 months ago • 2 comments

The DataPoint.has_bounds implementation is:

    def has_bounds(self) -> bool:
        return self.lower and self.upper

which will report false for self.lower = self.upper = 0.

Updating this check to self.lower is not None and self.upper is not None is probably more correct but breaks unit tests. (The log is too long to attach as a comment to this issue.)

This happens because we end up in compute_signficance from here because has_bounds() is now true and the compute_signficance method doesnt expect lower = upper = 0

┆Issue is synchronized with this Jira Task

freshstrangemusic avatar Oct 22 '24 20:10 freshstrangemusic