experimenter icon indicating copy to clipboard operation
experimenter copied to clipboard

Certain targeting expressions are failing inside of our targeting integration tests

Open data-sync-user opened this issue 1 year ago • 1 comments

While I was working on the fix for https://mozilla-hub.atlassian.net/browse/EXP-4834 I found that there were a few different targeting configs that weren’t passing. Using nimbus devtools, I was able to try them out and see that they evaluate fine but for some reason the script we are using for the integration tests throws an error b is null.

I have an HTML report of the errors from pytest but Jira wont let me upload it. I added extra logging output to the test which can be found within each of the failed tests on the report

┆Issue is synchronized with this Jira Bug

data-sync-user avatar Oct 01 '24 21:10 data-sync-user

➤ Benjamin Forehand Jr. commented:

Targeting strings that are showing errors:

  1. (attributionData.medium == 'email') && (version|versionCompare('120.!') >= 0)
  2. attributionData.medium == 'paidsearch') && (version|versionCompare('120.!') >= 0)
  3. ((isFirstRun && os.isWindows && os.windowsVersion >= 10 && isMSIX)) && (version|versionCompare('120.!') >= 0)
  4. ((isFirstStartup && !('trailhead.firstrun.didSeeAboutWelcome'|preferenceValue)) && (currentDate|date - profileAgeCreated|date) / 3600000 <= 24 && attributionData.medium == 'paidsearch') && (version|versionCompare('120.!') >= 0)
  5. ((isFirstStartup && !('trailhead.firstrun.didSeeAboutWelcome'|preferenceValue)) && attributionData.ua == 'chrome') && (version|versionCompare('120.!') >= 0)
  6. ((isFirstStartup && !('trailhead.firstrun.didSeeAboutWelcome'|preferenceValue)) && os.windowsBuildNumber >= 18362 && (currentDate|date - profileAgeCreated|date) / 3600000 <= 24 && !isDefaultBrowser && !doesAppNeedPin && attributionData.source != 'http://addons.mozilla.org ') && (version|versionCompare('120.!') >= 0)
  7. ((isFirstStartup && !('trailhead.firstrun.didSeeAboutWelcome'|preferenceValue)) && os.windowsBuildNumber >= 18362 && (currentDate|date - profileAgeCreated|date) / 3600000 <= 24 && !isDefaultBrowser && attributionData.medium == 'paidsearch') && (version|versionCompare('120.!') >= 0)
  8. ('sticky.targeting.test.pref'|preferenceValue) && (version|versionCompare('120.!') >= 0)
  9. (!isDefaultHandler['pdf'] && defaultPDFHandler['knownBrowser']) && (version|versionCompare('120.!') >= 0)
  10. ((os.isWindows && os.windowsVersion >= 10) && !hasActiveEnterprisePolicies && !isDefaultHandler.pdf && (!defaultPDFHandler.registered || defaultPDFHandler.knownBrowser)) && (version|versionCompare('120.!') >= 0)
  11. ((!os.isWindows || os.windowsVersion < 10) || hasActiveEnterprisePolicies || isDefaultHandler.pdf || (defaultPDFHandler.registered && !defaultPDFHandler.knownBrowser)) && (version|versionCompare('120.!') >= 0)

data-sync-user avatar Oct 02 '24 17:10 data-sync-user