experimenter icon indicating copy to clipboard operation
experimenter copied to clipboard

Published 20 hours ago • verified publisher icon mozilla

chore(nimbus): Fix for macos integration-tests.

Open b4handjr opened this issue 10 months ago • 2 comments

Because

  • MacOS seemed to have some issues with running the integration tests

This commit

  • Adds some changes to the makefile commands and updates the readme. The real fix was done upstream

Fixes #10548

b4handjr avatar Apr 10 '24 01:04 b4handjr

let me test this locally 💪

yashikakhurana avatar Apr 11 '24 17:04 yashikakhurana

tried locally, it is still crashing on local, we are investigating more on this

yashikakhurana avatar Apr 11 '24 22:04 yashikakhurana

Okay I will pull the branch again today and will test all the commands

yashikakhurana avatar May 06 '24 16:05 yashikakhurana

Instead of doing it this way, can we try reverting the base image hash back to the last working one?

This PR still doesn't seem to let me run the tests in a VNC container, which is (at least for me) the important local flow for the integration tests.

Sure, I just dont have much time to mess with it so I can't give an ETA

b4handjr avatar May 06 '24 16:05 b4handjr

Going to close this for now.

b4handjr avatar May 07 '24 14:05 b4handjr