code-review

code-review copied to clipboard

From [Bug 1600216](https://bugzilla.mozilla.org/show_bug.cgi?id=1600216)

La0

From https://bugzilla.mozilla.org/show_bug.cgi?id=1602552 Improvement patches miss a check when a task failure is also detected.

La0

Integration test

3

Start a new project in the repository to add a taskcluster hook that run every day at 7 AM CET and: 1. has a set of patches to test 2....

La0

So we can be more confident they are real failures and not intermittents. @jmaher suggested this.

marco-c

This could avoid issues like the one we had today, where we deployed to testing and we noticed a requirement was missing from events. Maybe running linting is enough to...

marco-c

We can just decide about one and get rid of the code for the other.

marco-c

As part of this, we also need to use `aresponses` or `aioresponses` instead of `responses`.

marco-c

I think the problem of duplicated messages doesn't apply. Reading a bit the documentation of RabbitMQ, it sounds like duplicated messages might not be possible. From https://www.rabbitmq.com/confirms.html#automatic-requeueing: > When manual...

marco-c

Once things settle down...

La0

Per Marco's comment [here](https://github.com/mozilla/code-review/pull/244#pullrequestreview-318371095). It would be a nice way to check that the validator keeps working

La0