code-review icon indicating copy to clipboard operation
code-review copied to clipboard

Store Phabricator builds from events

Open La0 opened this issue 5 years ago • 0 comments

This would be shipped after release 1.1.6. The idea is to make a request from events on the backend, on every new build being processed, in order to store the Phabricator build & target ids, on the Diff model. It should be pretty straightforward, as we already have access to the phabricator API from events, and are able to get informations for Diff, Revision & Repository.

The requests should be made right after the applied patch has been pushed on the try server (as we would then have the mercurial revision to use - which is required to create a Diff).

The review_task_id would become nullable as it's not created at the point in the patch timeline.

(Optional) A state field should also be added on the Diff model, as an enum:

  • pushed when the try push has just been made
  • done when the analysis has been done

It would then be possible to query the backend looking for a Diff on a try server at a specific mercurial revision (which is the only information we are certain to have on the decision task payload that the bot parses) , and retrieve the Phabricator build id needed to post updates

Would also help for #468, #461, #366

La0 avatar Feb 21 '20 14:02 La0