bugbug icon indicating copy to clipboard operation
bugbug copied to clipboard

Upgrade to use the latest version of `rust-code-analysis-web`

Open suhaibmujahid opened this issue 2 years ago • 8 comments

Upgrading the version from v0.0.23 to a higher version includes breaking changes. As a result, this requires reflecting the changes where needed (e.g., repository.py).

suhaibmujahid avatar Oct 14 '22 17:10 suhaibmujahid

picking this up

Amotul-raheem avatar Oct 15 '22 19:10 Amotul-raheem

@Amotul-raheem the latest version is v0.024 and it does not have a downloadable pre-built binary: https://github.com/mozilla/rust-code-analysis/releases/tag/v0.0.24, thus we cannot use it in the CI (at least not in the same way that we are doing now).

Maybe you want to wait for @marco-c to attach the pre-built binaries for v0.024 or release v0.025 with the pre-built binaries attached.

suhaibmujahid avatar Oct 15 '22 20:10 suhaibmujahid

Alright got it thanks!

Amotul-raheem avatar Oct 15 '22 20:10 Amotul-raheem

We have released 0.0.25, we should upgrade to it.

marco-c avatar Jan 13 '23 11:01 marco-c

Hello, I would like to work on this, I would appreciate if you would give me a lead, on how to go about this. Thank you

Munaelekwa avatar Mar 10 '23 08:03 Munaelekwa

Hello, I would like to work on this, I would appreciate if you would give me a lead, on how to go about this. Thank you

Here is where we download rust-code-analysis-web:

https://github.com/mozilla/bugbug/blob/f9906057a5281b8913fb5a92edbe73440953581b/.taskcluster.yml#L94

Currently, we are using v0.0.23 where the latest version is v0.0.25. We need to upgrade to the latest version; however, the latest version introduces some breakage changes, see https://github.com/mozilla/bugbug/issues/3117#issue-1409634850.

To work on this, you may want to start by installing/building rust-code-analysis.

Once you have v0.0.25 installed on your system, you could run the tests to check for breakage changes and fix them, for example:

python -m pytest tests/test_repository.py

suhaibmujahid avatar Mar 14 '23 13:03 suhaibmujahid

Hello, I would like to work on this, I would appreciate if you would give me a lead, on how to go about this. Thank you

Here is where we download rust-code-analysis-web:

https://github.com/mozilla/bugbug/blob/f9906057a5281b8913fb5a92edbe73440953581b/.taskcluster.yml#L94

Currently, we are using v0.0.23 where the latest version is v0.0.25. We need to upgrade to the latest version; however, the latest version introduces some breakage changes, see #3117 (comment).

To work on this, you may want to start by installing/building rust-code-analysis.

Once you have v0.0.25 installed on your system, you could run the tests to check for breakage changes and fix them, for example:

python -m pytest tests/test_repository.py

Thanks, I'm on it!

Munaelekwa avatar Mar 16 '23 11:03 Munaelekwa

I have updated the rust-code-analysis-web: to the latest version, I have few questions to continue fixing the

Error cloning repository: Command '['hg', 'robustcheckout', b'--purge', b'--sharebase=ciao-shared', b'--networkattempts=7', b'--branch=tip', b'--noupdate', b'--', '/tmp/pytest-of-fadebowaley/pytest-57/test_clone0/repos/remote', 'ciao']' returned non-zero exit status 255.

I noticed robustcheckout is called by hg which is not availlable is there a way I can check out thes update in the new version v0.0.25

fadebowaley avatar Mar 21 '23 03:03 fadebowaley