bugbug icon indicating copy to clipboard operation
bugbug copied to clipboard

Published 20 hours ago • verified publisher icon mozilla

post-patch

Open anooptp opened this issue 3 years ago • 7 comments

Fixes #1718

anooptp avatar Dec 15 '21 17:12 anooptp

@marco-c - Could you please provide your inputs.

anooptp avatar Dec 26 '21 06:12 anooptp

Sorry I was on holidays. It looks reasonable so far. Did you manage to test it to see that the data was passed correctly to the apply_patch function?

marco-c avatar Jan 03 '22 16:01 marco-c

Sorry I was on holidays. It looks reasonable so far. Did you manage to test it to see that the data was passed correctly to the apply_patch function?

yes, I can see that the value is getting passed.

image

anooptp avatar Jan 04 '22 18:01 anooptp

Any specific format in which patch data needs to be passed?

anooptp avatar Jan 04 '22 18:01 anooptp

Any specific format in which patch data needs to be passed?

It can be plain text

marco-c avatar Jan 11 '22 08:01 marco-c

Sorry I was on holidays. It looks reasonable so far. Did you manage to test it to see that the data was passed correctly to the apply_patch function?

yes, I can see that the value is getting passed.

image

What you're showing is the log from https://github.com/mozilla/bugbug/pull/2679/files#diff-ca8f2b585c0d22a63ede5aea635f3266fcf60181a7e6cd395c6a3e49916beda7R842. Is the data also arriving on the worker side, at https://github.com/mozilla/bugbug/pull/2679/files#diff-cf49a1f79f836b960b0e15cc583bf3e73016b7c7e3d0e13398ddc35d004a3fa8R244?

marco-c avatar Jan 11 '22 08:01 marco-c

Sorry I was on holidays. It looks reasonable so far. Did you manage to test it to see that the data was passed correctly to the apply_patch function?

yes, I can see that the value is getting passed.

What you're showing is the log from https://github.com/mozilla/bugbug/pull/2679/files#diff-ca8f2b585c0d22a63ede5aea635f3266fcf60181a7e6cd395c6a3e49916beda7R842. Is the data also arriving on the worker side, at https://github.com/mozilla/bugbug/pull/2679/files#diff-cf49a1f79f836b960b0e15cc583bf3e73016b7c7e3d0e13398ddc35d004a3fa8R244?

worker node is taking a lot of time to come up. So, not able to test it locally. Is there any alternative way to test it.

image

image

anooptp avatar Jan 11 '22 12:01 anooptp

Closing for lack of updates, feel free to reopen if you still intend to work on this.

suhaibmujahid avatar Mar 10 '23 13:03 suhaibmujahid