blurts-server icon indicating copy to clipboard operation
blurts-server copied to clipboard

Blue links in emails should be consistently styled

Open lesleyjanenorton opened this issue 3 years ago • 5 comments

'Unsubscribe' and 'Frequently Asked Questions' should match other blue links. Screen Shot 2021-07-26 at 9 05 41 PM

lesleyjanenorton avatar Jul 27 '21 02:07 lesleyjanenorton

Hi , I would like to work on this issue.

Amod02-prog avatar Sep 11 '22 20:09 Amod02-prog

Can you direct me to the location of the file issue.

Amod02-prog avatar Sep 11 '22 20:09 Amod02-prog

The text is translated, and identified by email-footer-blurb

The code that generates the HTML fragment is: https://github.com/mozilla/blurts-server/blob/a25eaecee9b9d132cd027f3d9cdb0d07e366dd7e/template-helpers/emails.js#L217-L237

I think this issue is the browser is styling visited links differently than unvisited links. I'm not sure if we want to override that.

jwhitlock avatar Sep 12 '22 16:09 jwhitlock

@jwhitlock I don't think you are wrong here . I looked through the code and as you thought the links that can be visited are styled differently than rest . But in that piece of code , there are no indications to "Have I Been Pwned" yet still its been highlighted . I think that it could be a simple css color coding error where he first two and the last two have been given two different color codes which can be corrected easily except I am unable to find the .html file for that page or the .css file

Amod02-prog avatar Sep 16 '22 11:09 Amod02-prog

@lesleyjanenorton Can you comment the link where we can see this result

Amod02-prog avatar Sep 16 '22 11:09 Amod02-prog

Closing since we've redesigned the site and functionality since this was created. If you feel that this is still needed, please let me know.

EMMLynch avatar Mar 08 '24 15:03 EMMLynch