mozilla
Drop release-notes and sys reqs views (and HTML pages) from Bedrock now we're redirecting to www.firefox.com
Description
Now we're redirecting release-notes pages to www.firefox.com, they have been rendered redundant in bedrock. We should drop this stale code, but we must make sure we still retain the redirects from www.m.o to www.firefox.com because there are lots of URLs in the wild pointing at www.mozilla.org for release notes
Success Criteria
- [ ] Redundant views, URLconf, HTML, CSS and JS for release-notes and system-requirements pages are dropped
- [ ] Redirects for release notes and system requirements pages to www.firefox.com are still present and working
Hi @stevejalim , I would like to work on this issue. Can you please confirm if this is open for contributors and if there are any specific guidelines for handling the redirects from www.mozilla.org to www.firefox.com? Thanks!
Hi @Aman202600 - thanks for your interest. This isn't a small ticket, but you're welcome to take a swing at it.
The main focus here is removing the views, templates, etc as per the first success criterion. Off the top of my head, that'll mean dropping the releasenotes app from the codebase, related CSS and JS from src and also updating static-bundles.json. You'll know when it's all working when make clean build completes fine, I think.
The release-notes redirects are actually in the separate firefox app, not the releasenotes app https://github.com/mozilla/bedrock/blob/main/bedrock/firefox/redirects.py so should be fine to leave untouched, but there's a possibility that there's sometihng that imports from the bedrock.releasenotes app and will break.
To give me an idea of how familiar you are at the moment with the project, have you already got Bedrock running locally?
Hi @stevejalim, Thank you for the detailed explanation and guidance.I’m currently setting up Bedrock locally to understand the structure better. Once I have it running, I’ll start working on removing the releasenotes app and related assets, and then test using make clean build.If I encounter any issues with dependencies or redirects, I’ll reach out for clarification.
Sounds good to me @Aman202600 - let us know how you go! We appreciate your contribution!
There are also tests, and test fixtures — so a question is whether that's all contained in the app, or there's more things using the notes test mocks for anything / i.e. whether these are also safe to remove without a replacement.
My guess is the non-trivial bits tracking down the data sources, if they're no longer used anywhere else, would be a) removing the cron jobs pulling git data for these, removing the git repos from various scripts, health checks etc. b) removing the models, meaning dropping database content? i.e. some migration is in cards for that?
Removing the models will leave the DB tables orphaned. We can clean those us manually later as a follow-on task, yeah