application-services icon indicating copy to clipboard operation
application-services copied to clipboard

Add ohttp support to the Android megazord [ci full]

Open bendk opened this issue 1 month ago • 2 comments

Upgrading ohttp to the latest version, which is needed to make the builds work.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • [ ] This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • [ ] Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • [ ] Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

bendk avatar Nov 18 '25 14:11 bendk

I think ohttp is not building 0.7.1 at the moment due to: https://github.com/martinthomson/ohttp/issues/85

A workaround:

[patch.crates-io]
generic-array = "=0.14.7"

I tested the latest main from the ohttp crate and build it locally with cargo update -p generic-array --precise 0.14.7 and it works.

gruberb avatar Nov 29 '25 23:11 gruberb

I just rebased this branch, we'll see what happens with generic-array. I think it'll be okay in app-services, because we're using 0.14.5 in our lock file. However, we may hit that issue when we vendor this into moz-central.

bendk avatar Dec 01 '25 16:12 bendk