Bug 1882954 - Expose icon mimetype in suggestions

[dadaa]

trafficstars

Currently, if the blob content of the icon contained in suggestion from Rust is SVG, the image will be broken unless specify the mimetype. Especially for Yelp Suggestion, as it uses SVG icon, we specify the mimetype explicitly. https://searchfox.org/mozilla-central/rev/da2c1e64cc7aa8718fb92eb602136da5d505d664/browser/components/urlbar/private/SuggestBackendRust.sys.mjs#141 However, we ideal to use mimeytpe specified in RemoteSettings to think in the future as well. This PR exposes the mimetype to create the icon image.

And its JS code: https://phabricator.services.mozilla.com/D203237

Pull Request checklist

• Breaking changes: This PR follows our breaking change policy
  • [ ] This PR follows the breaking change policy:
    • This PR has no breaking API changes, or
    • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
• [ ] Quality: This PR builds and tests run cleanly
  • Note:
    • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
    • If this pull request includes a breaking change, consider cutting a new release after merging.
• [ ] Tests: This PR includes thorough tests or an explanation of why it does not
• [ ] Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
  • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
• [ ] Dependencies: This PR follows our dependency management guidelines
  • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.08%. Comparing base (a70d9ca) to head (cd709a8).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6151   +/-   ##
=======================================
  Coverage   84.08%   84.08%           
=======================================
  Files         117      117           
  Lines       15629    15629           
=======================================
  Hits        13141    13141           
  Misses       2488     2488           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[dadaa]

Thank you very much! I will address your comments.

[0c0w3]

We had a super interesting bug ages ago in bookmark sync, where a left join on multiple columns for 40k rows caused a query to take over 4 minutes—but using a functionally equivalent correlated subquery took just 2 seconds. That edge case doesn't apply here, though! ☺️

@linabutler oh wow, do you happen to remember if the query plans were the same (apologies if that's what you mean by functionally equivalent)? Did you figure out the root cause? I seem to recall a similar problem and subquery fix when I worked on Places, but that was years ago and I don't remember the details. I'd like to refresh my knowledge on this, if you happen to remember.