application-services icon indicating copy to clipboard operation
application-services copied to clipboard

[ci full] Trying to untangle rusqlite feature flags

Open mhammond opened this issue 2 years ago • 1 comments

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • [ ] This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • [ ] Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • [ ] Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

mhammond avatar Nov 24 '23 22:11 mhammond

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (11b6f77) 26.97% compared to head (ff02131) 30.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5944      +/-   ##
==========================================
+ Coverage   26.97%   30.64%   +3.66%     
==========================================
  Files         377      367      -10     
  Lines       47881    42147    -5734     
==========================================
  Hits        12916    12916              
+ Misses      34965    29231    -5734     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Nov 24 '23 22:11 codecov-commenter