application-services icon indicating copy to clipboard operation
application-services copied to clipboard

Update sync15 BSO concept to use envelopes and kill sync15::Payload.

Open mhammond opened this issue 3 years ago • 1 comments

mhammond avatar Sep 15 '22 03:09 mhammond

.

mhammond avatar Sep 15 '22 03:09 mhammond

Thanks Ben - I did most of your comments in 341ffa923e09e947f341922d6559df8d915c27e8, so if you don't mind looking over that to make sure I didn't misunderstand your ideas it would be great. I think I'll open a new issue for the error reporting and do it as a followup just to stop this getting bigger than Ben Hur!

mhammond avatar Oct 06 '22 07:10 mhammond

Codecov Report

Base: 41.00% // Head: 42.27% // Increases project coverage by +1.26% :tada:

Coverage data is based on head (96aeb42) compared to base (914ac9c). Patch coverage: 43.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5139      +/-   ##
==========================================
+ Coverage   41.00%   42.27%   +1.26%     
==========================================
  Files         170      173       +3     
  Lines       12850    12976     +126     
==========================================
+ Hits         5269     5485     +216     
+ Misses       7581     7491      -90     
Impacted Files Coverage Δ
...nents/fxa-client/src/internal/commands/send_tab.rs 0.00% <0.00%> (ø)
components/sync15/src/bso/crypto.rs 0.00% <0.00%> (ø)
components/sync15/src/bso/test_utils.rs 0.00% <0.00%> (ø)
components/sync15/src/client/coll_update.rs 0.00% <0.00%> (ø)
components/sync15/src/client/collection_keys.rs 0.00% <0.00%> (ø)
components/sync15/src/client/request.rs 0.00% <0.00%> (ø)
components/sync15/src/client/state.rs 0.00% <0.00%> (ø)
components/sync15/src/client/storage_client.rs 0.00% <0.00%> (ø)
components/sync15/src/clients_engine/engine.rs 0.00% <0.00%> (ø)
components/sync15/src/clients_engine/record.rs 0.00% <ø> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Oct 06 '22 07:10 codecov-commenter